-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeat() and DelayAfter() on the same effect in a sequence #122
Comments
I realized that for my use case, I can add an extra space (" ") at the end of the |
Thanks for the report - I can confirm that there is a problem in the |
because this reveales the root cause of #122, that false is returned while the effect is acutally running
* also check the outcome of Update() in tests because this reveales the root cause of #122, that false is returned while the effect is acutally running * upgrade to catch2 v3 * update platformio to 6.1.10 * release 4.13.1 * update coversall action
fixed with 4.13.1, please check if it's ok now |
Works a treat, thank you! |
When I run code like this, I would expect the first effect to repeat three times with a delay of three seconds after each time. But the first effect runs once and then it moves on to the next effect. Am I missing something?
It looks like
Repeat()
alone works as expected butDelayAfter()
alone does not.Modified from https://github.com/jandelgado/jled/blob/master/examples/sequence/sequence.ino.
Thanks a bunch for the Morse example, I'm using it for exactly that purpose (to key a radio). The use case is that I want to repeat a Morse message n times, then wait a number of seconds. But without
DelayAfter()
on the message, the final dit and the first dah run together.The text was updated successfully, but these errors were encountered: