Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add period to on and off effects #93

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Add period to on and off effects #93

merged 2 commits into from
Mar 25, 2022

Conversation

jandelgado
Copy link
Owner

@jandelgado jandelgado commented Mar 25, 2022 •
edited
Loading

On, Off and Set now take an optional duration value, making these effects behave like any other in this regard. This allows to add an On effect to a JLedSequence for a specific amount of time.

@jandelgado jandelgado force-pushed the add_period_to_on_and_off_effects branch from 57b50d4 to 0aa254c Compare March 25, 2022 20:22
@coveralls
Copy link

coveralls commented Mar 25, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.97% when pulling c9fa659 on add_period_to_on_and_off_effects into 1971249 on master.

@jandelgado jandelgado force-pushed the add_period_to_on_and_off_effects branch from 0aa254c to ea41cc0 Compare March 25, 2022 20:24
@jandelgado jandelgado force-pushed the add_period_to_on_and_off_effects branch from ea41cc0 to c9fa659 Compare March 25, 2022 20:27
@jandelgado jandelgado merged commit 8380506 into master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jandelgado @coveralls