Changed np.bool to np.bool_ as those have been depreciated. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harshcurious thank you for the PR! LGTM note that the CI is failing because of unrelated issues. If that is ok for you I will add a couple of commits to this branch to fix it (once I have some time:). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations
Note that there a difference between the two.
np.boolwas actually just an alias for the built-inbool, whereasnp.bool_is a numpy scalar. Thenp.bool_is stored as a byte and is not a subclass of theint_type. Ref: https://numpy.org/doc/stable/reference/arrays.scalars.html#numpy.bool_