fix(rbac): reduce number of transactions for admin role

[PatAKnight]

Description

Fixes the issue where an error is thrown whenever the RBAC Backend plugin configuration values are not set within the app-config. Namely, the problem happened whenever an admin was not set in the app-config.

The issue seemed to be happening because a transaction was not being committed properly and was not freeing up. This in turn would result in the following error

ForwardedError [KnexTimeoutError]: Plugin 'permission' startup failed; caused by KnexTimeoutError: Knex: Timeout acquiring a connection. The pool is probably full. Are you missing a .transacting(trx) call?

The fix was to have it so that the role metadata transaction and the admin roles transaction are now shared.

Fixes

• Fixes: RHIDP-3282

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pataknight. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[AndrienkoAleksandr]

Alternative fix is here: #1923

[AndrienkoAleksandr]

We talked with @PatAKnight. Both fixes make sense. I cherry-picked this fix to pr: #1923

[PatAKnight]

Closing in favor of #1923