Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argocd): add support for fetching an application by app name #1924

Merged

Conversation

karthikjeeyar
Copy link
Contributor

Fixes:

https://issues.redhat.com/browse/RHTAP-2849

Description:

Add support to fetch only the application thats matches the name defined in argocd/app-name annotation.

How to test

  1. Add a Gitops Application in a namespace
  2. Use the following annotation to fetch that single application in Argo CD plugin
        metadata:
            annotations:
               ....
               argocd/app-name: quarkus-app

Screenshots

Argocd_application

cc: @rohitkrai03

@karthikjeeyar karthikjeeyar requested a review from a team as a code owner July 23, 2024 11:22
Copy link

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pataknight for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Eswaraiahsapram
Copy link
Contributor

/lgtm

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

sonarcloud bot commented Aug 9, 2024

@Eswaraiahsapram
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d7e3a7c into janus-idp:main Aug 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants