Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the None host with binary logs #120

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Using the None host with binary logs #120

merged 3 commits into from
Apr 27, 2024

Conversation

jaredpar
Copy link
Owner

Before this change using the None host with a binary log required round tripping to a compiler log first. Now it can just be done directly on a binary log.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 97.18%. Comparing base (82b20ae) to head (c50c377).

Files Patch % Lines
src/Basic.CompilerLog.Util/RoslynUtil.cs 80.19% 12 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   97.16%   97.18%   +0.01%     
==========================================
  Files          41       41              
  Lines        3947     3975      +28     
  Branches      391      394       +3     
==========================================
+ Hits         3835     3863      +28     
  Misses         59       59              
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredpar jaredpar merged commit 866649d into main Apr 27, 2024
4 of 5 checks passed
@jaredpar jaredpar deleted the none-host branch April 27, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant