Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read TF out of GlobalProperties #138

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Read TF out of GlobalProperties #138

merged 1 commit into from
Jun 10, 2024

Conversation

jaredpar
Copy link
Owner

Turns out the target framework can be included in GlobalProperties as well. Need to consult that when building up compilations.

Turns out the target framework can be included in `GlobalProperties` as
well. Need to consult that when building up compilations.
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.82%. Comparing base (7dba67b) to head (5156709).

Files Patch % Lines
src/Basic.CompilerLog.Util/BinaryLogUtil.cs 90.74% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   96.83%   96.82%   -0.01%     
==========================================
  Files          43       43              
  Lines        4233     4221      -12     
  Branches      426      425       -1     
==========================================
- Hits         4099     4087      -12     
  Misses         73       73              
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredpar jaredpar merged commit c310985 into main Jun 10, 2024
3 of 5 checks passed
@jaredpar jaredpar deleted the prop branch June 10, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant