Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing against outdated vendor libraries #4271

Open
jgonggrijp opened this issue Jul 21, 2023 · 1 comment
Open

Testing against outdated vendor libraries #4271

jgonggrijp opened this issue Jul 21, 2023 · 1 comment

Comments

@jgonggrijp
Copy link
Collaborator

The project is currently testing against local hardcopies of jQuery, json2, QUnit, require.js and Underscore. These versions are all outdated by at least seven years.

There is a real advantage to this: testing against old versions of dependencies safeguards backwards compatibility.

There is also an obvious disadvantage: the more outdated these dependencies become, the more likely it is that incompatibilities creep into newer versions, without the tests detecting them.

In my own projects, I use Backbone with the latest versions of Underscore and jQuery, and I haven't noticed any problems. So far, we might have gotten away with the outdatedness of the dependencies, thanks to the fact that jQuery and Underscore are both very stable. However, at some point, this streak of luck will likely end.

I am convinced that we need to test against recent versions of jQuery and Underscore. They can simply be sourced from the node_modules instead of test/vendor. I am less sure about the old versions; should we keep also testing against those or not?

Thoughts appreciated. CC @GammaGames

@GammaGames
Copy link

Wow, that version of jquery released almost 11 years ago! I've been using recent versions in our projects and haven't come across any issues, underscore at 1.13.2 and jquery at 3.6.3. I don't really see any value in testing against versions that old.

jgonggrijp added a commit to jgonggrijp/backbone that referenced this issue Jul 26, 2023
This silences a Rollup warning about unresolved dependencies. However,
it may come in handy for testing, too; see jashkenas#4271.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants