Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use allowed instead of whitelisted; Use disallowed instead of blacklisted; #4287

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

xwxtwd
Copy link
Contributor

@xwxtwd xwxtwd commented Feb 23, 2024

1.Use allowed instead of whitelisted.
2.Use disallowed instead of blacklisted.

Copy link
Collaborator

@jgonggrijp jgonggrijp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowed/disallowed reads more natural in my opinion. This is also the wording we went with in current Underscore. Other than that, I'm happy to merge this, but please keep in mind that your changes have relatively little effect:

  • This is a copy of Underscore that is never shipped to users. It is only used in testing.
  • Underscore proper is not updated by your changes, although it also does not need them anymore.
  • This copy will likely disappear eventually in favor of a copy installed from NPM, or otherwise it will at least be updated to a more recent version of Underscore.

@xwxtwd xwxtwd changed the title Use allowlisted instead of whitelisted; Use blocklisted instead of bl… Use allowed instead of whitelisted; Use disallowed instead of blacklisted; Feb 25, 2024
@xwxtwd
Copy link
Contributor Author

xwxtwd commented Feb 25, 2024

Done.😀

Copy link
Collaborator

@jgonggrijp jgonggrijp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgonggrijp jgonggrijp merged commit c73855b into jashkenas:master Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants