Test PRs are added to the bottom #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,6 +1,6 @@ | |||
| <%= form_tag(budget_executions_path(budget), method: :get, class: "budget-executions-filters") do %> | |||
| <div class="filter"> | |||
| <%= label_tag :milestone_tag, t("budgets.executions.filters.milestone_tag.label") %> | |||
| <%= label_tag :milestone_tag,t("budgets.executions.filters.milestone_tag.label") %> | |||
There was a problem hiding this comment.
Layout/SpaceAfterComma: Space missing after comma. (https://rubystyle.guide#spaces-operators)
| @@ -1,7 +1,7 @@ | |||
| (function() { | |||
| "use strict"; | |||
| App.LegislationAnnotatable = { | |||
| makeEditableAndHighlight: function(colour) { | |||
| makeEditableAndHighlight: function( colour) { | |||
There was a problem hiding this comment.
There should be no spaces inside this paren.
| @@ -3,6 +3,7 @@ class Administrator | |||
| include CanCan::Ability | |||
|
|
|||
| def initialize(user) | |||
|
|
|||
There was a problem hiding this comment.
Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
| @@ -24,7 +24,8 @@ | |||
| height: rem-calc(14); | |||
| position: relative; | |||
|
|
|||
| .meter { | |||
| .meter | |||
| { | |||
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
javierm
force-pushed
the
test_permissions
branch
from
f21aa4b
to
711d9a1
Compare
javierm
changed the title
javierm
force-pushed
the
master
branch
4 times, most recently
from
ef56d20
to
8a3c6bd
Compare
javierm
force-pushed
the
master
branch
5 times, most recently
from
389e201
to
7c86945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.