Add all budget changes #18

javierm · 2020-06-01T21:10:41Z

Everything here.

Previously the draft mode was a phase of the PB, but that had some limitations. Now the phase drafting disappears and therefore the PB can have the status published or not published (in draft mode). That will give more flexibility in order to navigate through the different phases and see how it looks for administrators before publishing the PB and everybody can see. By default, the PB is always created in draft mode, so it gives you the flexibility to adjust and modify anything before publishing it.

We've got a "publish" action, so having it as a hidden field as well is a bit fragile and allows users to "unpublish" a budget (even, though, of course, most admins wouldn't want to "hack" their own applcation).

The show action only renders edit, so it isn't really useful.

While this use is harmless since it's in the admin section and publishing a published budget does nothing, it's good to use abilities to define permissions so developers being inspired by existing code follow this practice as well.

- Add main button to budgets - Ability to attach an image to budgets - Add main button to each phase of the budget - Ability to edit the name of the budget phases - Ability to attach an image to budget phases - Ability to create single heading budgets step by step - UX improvements on the participatory budgets (public and admin)

Taken from a later commit

Co-Authored-By: Julian Nicolas Herrero <[email protected]>

Before, users needed to navigate to the list of groups in order to add, edit or delete a group. Also, they need to navigate to the list of groups first, and then to the list of headings for that group in order to add, edit or delete a heading. Now, it's possible to do all these actions for any group or heading from the participatory budget view to bring simplicity and to reduce the number of clicks from a user perspective.

Co-Authored-By: Julian Nicolas Herrero <[email protected]>

Appart from 'balloting', there are more phases between 'publishing_prices' and 'finshed'. So, it doesn't make sense that the filter 'selected' is only applied to those two. With this change the filter will be applied as follow: 'not_unfeasible' for phases: - informing - accepting - reviewing - selecting - valuating selected for phases: - publishing_prices - balloting - reviewing_ballots winners for phases: - finished

This clas was used before, but since the new style for budgets is not needed anymore

Since this partial will only be rendered for budgets with only one heading, it does not make sense to iterarte over all groups and headings

There was a big difference between the current budget and a specific budget landing page. This didn't really make too much sense. Also, it was not possible to know how a draft participatory budget will look before it was published. By unifying those two views now they will look quite similar and it will be possible for administrators to preview any draft budget and to know how the budget will look like before actually publishing it.

Improve styles for budgets voting phase

houndci-bot · 2020-06-01T21:11:13Z

spec/lib/graphql_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"

-api_types  = GraphQL::ApiTypesCreator.create(GraphqlController::API_TYPE_DEFINITIONS)
+api_types  = GraphQL::ApiTypesCreator.create


Rails/SaveBang: Use create! instead of create if the return value is not checked. Or check persisted? on model returned from create. (https://rails.rubystyle.guide#save-bang)

houndci-bot · 2020-06-01T21:11:13Z

app/controllers/graphql_controller.rb

@@ -29,7 +29,7 @@ def query
  private

    def consul_schema
-      api_types  = GraphQL::ApiTypesCreator.create(API_TYPE_DEFINITIONS)
+      api_types  = GraphQL::ApiTypesCreator.create


Rails/SaveBang: Use create! instead of create if the return value is not checked. Or check persisted? on model returned from create. (https://rails.rubystyle.guide#save-bang)

Insert new texts in locale filse

* #18 Partial implementation for user verification * #18 Add validation for CNP * #18 Add working implementation for validation * #18 Fix unsafe stripping * Add test for CNP validation, split up terms checkboxes Add a very basic system spec for the new CNP verification flow. Split up the checkbox to accept terms, residency, and adult status into three separate checkboxes. Co-authored-by: tsundokul <[email protected]>

… master Reviewed-on: https://git.nubarron.teide.int/shs-consul/cabildoabierto-consul/pulls/18

microweb10 and others added 30 commits May 31, 2020 18:08

Fix typos

95626d4

Simplify published attribute

391d6c0

We've got a "publish" action, so having it as a hidden field as well is a bit fragile and allows users to "unpublish" a budget (even, though, of course, most admins wouldn't want to "hack" their own applcation).

Simplify render calls

fb3740a

Use edit action in admin

3c08aac

The show action only renders edit, so it isn't really useful.

Remove unneeded code; might add it later if needed

8bb8add

Simplify condition

02cb7fa

Use can? to show links to actions

c39430d

While this use is harmless since it's in the admin section and publishing a published budget does nothing, it's good to use abilities to define permissions so developers being inspired by existing code follow this practice as well.

Use before action for methods used in more than one action

b2d9cf3

Add rakes to adjust existing budgets

652041a

Fix typo

343b510

Update tests to Capybara 3.x

01169c0

Add proper texts

ed1941b

Taken from a later commit

Add custom translations for NL

05ed27a

Show results and stats settings only in budget edit view

44b95dc

Add groups and headings settings in admin budget edit

ba825f1

Change scss lint max depth to 5

bda3ab0

Add link to top feature

a314601

Remove link to edit groups on admin budgets index

fe59297

Extract budget groups and headings table to a partials

2a07a06

Multiple heading budget creation by steps (step groups)

af5bbae

Co-Authored-By: Julian Nicolas Herrero <[email protected]>

Multiple heading budget creation by steps (step headings)

31472c1

Move partial to the phases namespace

1e932f0

Participatory budgets creation by steps (add step for phases)

5a3d5bd

Redirect to budget view when editing a budget from admin panel

ec1f5cd

Add link to remove budget on budget admin index

a79e591

Fix reveal styles when resizing and add missing translations

bd1157a

Improves spacing for forms layout

f0997e1

decabeza and others added 24 commits June 1, 2020 14:57

Improve budgets phases color contrast and sizes

1f877ee

Fix button alignment in budget index subheader

a9300de

Add helper to show budget phase name

2ef42a7

Add phase name on budget phases tabs navigation

fe7fb04

Hide single heading select on new budget investment form

9316154

Update styles and layout for new budget investment form

f2905fc

Show heading name and amount on single heading new form

e79cb95

Show a preview list of investments in the budget landing page

103c5ef

Co-Authored-By: Julian Nicolas Herrero <[email protected]>

Extract budget investment's info to a partial

f12b1bd

Add custom nl translations

abd4415

Remove unnecessary class

8b3290b

This clas was used before, but since the new style for budgets is not needed anymore

Update partial for a single heading budget

bb96b3b

Since this partial will only be rendered for budgets with only one heading, it does not make sense to iterarte over all groups and headings

Extract title for budgets to a partial

697e4a5

Extract footer for budgets to a partial

e59028c

Make finished budgets layout wider

7ee0a40

Avoid scroll on phases navigation and fix typo

e2753f8

Fix budget button styles

9977682

Add styles to groups index page

f5371cc

Fix heading tag hierarchy on budgets index

fb9b09b

Add filters on budget investments index page

9d9a21d

Add supports info section on budgets index page

28b7a8f

Improve styles for budgets voting phase (#20)

75fba33

Improve styles for budgets voting phase

houndci-bot reviewed Jun 1, 2020

View reviewed changes

javierm changed the base branch from master to rails5.2_compatibility June 2, 2020 16:46

javierm pushed a commit that referenced this pull request Sep 29, 2021

Merge pull request #18 from Usabi/issue/3430

36709a4

Insert new texts in locale filse

javierm closed this Oct 25, 2021

javierm added a commit that referenced this pull request Feb 15, 2023

Merge pull request 'Fix schema.rb file' (#18) from fix_db_schema into…

9ee98c5

… master Reviewed-on: https://git.nubarron.teide.int/shs-consul/cabildoabierto-consul/pulls/18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add all budget changes #18

Add all budget changes #18

javierm commented Jun 1, 2020

houndci-bot Jun 1, 2020

houndci-bot Jun 1, 2020

Add all budget changes #18

Add all budget changes #18

Conversation

javierm commented Jun 1, 2020

houndci-bot Jun 1, 2020

Choose a reason for hiding this comment

houndci-bot Jun 1, 2020

Choose a reason for hiding this comment