Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coveralls not running on pull requests #189

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Commits on Mar 1, 2023

  1. Use my repo

    javierm committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    aaeb274 View commit details
    Browse the repository at this point in the history
  2. Run test coverage just on the master branch

    Since we changed the way we integrate coveralls in commit 8ed8cc8,
    we're getting 6 additional checks displayed in our pull requests.
    
    We don't need these checks, and they only add noise. The only reason we
    use coveralls is to know the test coverage in our master branch.
    
    So we're changing the code so coveralls only runs on the master branch.
    
    There's also a chance that the test suite will be faster because it
    doesn't need to keep track of the coverage, although I haven't noticed any
    significant differences during my tests.
    
    I haven't found a more elegant way to say that a certain step should
    only be run on push on master, so I'm setting the environment variable
    we were already using.
    javierm committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    7c86945 View commit details
    Browse the repository at this point in the history
  3. Try log rotation TODO: there might be side effects; ADD RELEASE NOTES!

    Code based on the logger Rails uses by default; as mentioned in the
    Rails configuration guide:
    
    > [the logger] defaults to an instance of ActiveSupport::TaggedLogging
    > that wraps an instance of ActiveSupport::Logger which outputs a log to
    > the log/ directory. You can supply a custom logger, to get full
    > compatibility you must follow these guidelines:
    >
    > * To support a formatter, you must manually assign a formatter from
    >   the config.log_formatter value to the logger.
    > * To support tagged logs, the log instance must be wrapped with
    >   ActiveSupport::TaggedLogging.
    > * To support silencing, the logger must include
    >   ActiveSupport::LoggerSilence module. The ActiveSupport::Logger class
    >   already includes these modules.
    javierm committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    8141652 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. Configuration menu
    Copy the full SHA
    ecc62ea View commit details
    Browse the repository at this point in the history