-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pip>=20.3 support #1216
Add pip>=20.3 support #1216
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
- Coverage 99.50% 99.44% -0.07%
==========================================
Files 36 36
Lines 2855 2863 +8
Branches 332 336 +4
==========================================
+ Hits 2841 2847 +6
- Misses 8 9 +1
- Partials 6 7 +1
Continue to review full report at Codecov.
|
@atugushev Looks like we've got to add compatibility for the new merging of
EDIT: Please see the new commit. |
Ideally we can push a release out before the |
The 2.3 beta 1 is now on pypi https://pypi.org/project/pip/20.3b1/ |
d1d6091
to
bb2cea7
Compare
OK, we've got at least one more recent change in
|
Notes on the
|
I'm trying to understand the use and purpose of
I welcome any extra notes from @techalchemy Link to that comment I don't understand yet. Obviously it resolves dependencies. It partially may be about filtering direct requirements from the results. It also looks like it's used to "prepare" the reqs. For now I'm trying using I also now realize that the pip version checks we already have in this PR are not going to cut it when the user has newer pip, but passes We may want to modify most or all of the compile cli tests to run again with that option, if the pip version is new enough... |
Looks like it's going GA very soon: pypa/pip#8936 (comment) |
Ask me anything you want, regarding the new resolver in pip and the internal model/design of the various components (from pip's PoV)! :) |
@AndydeCleyre thank you very much for helping me with
It seems for now we should pass @pradyunsg thank you! Your assistance would help a lot when we start to work on the new resolver! |
I'm sorry I haven't been more helpful on this. |
It's ready for review, and yeah it's better to merge and release this before pip-20.3 being released (which is today 😰) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@vphilippon thanks for reviewing this! I'll merge this then eagerly if nobody minds. |
Ah, no I can't. Travis is still |
@atugushev Yeah I saw that. I cancelled and retried the build in hope to get it unstuck, but to no avail. |
@vphilippon not that I'm aware of. Maybe we have reached free credit for free usage? See also jazzband/help#206 (comment) |
I'd suggest turning Travis CI off, because they have an open source plan "in progress" and not actually rolled out to any project AFAIK. The one-time credit limit they announced is like 16 hours of CI time, which just isn't enough. |
#1229 is the relevant PR. :) |
Raku is the only project I've seen which has been granted something: I've applied but not got anything yet. But, yeah, #1229 :) |
Thanks for the quick turnaround all! |
pip=>20.3
tox -e pipprevious
pip
Changelog-friendly one-liner: Add
pip>=20.3
support.Contributor checklist