-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update types using fresh dependencies #1927
base: main
Are you sure you want to change the base?
Conversation
FYI, this is pre-step towards addressing the following comments: |
FWIW it might be useful to run mypy against several pip and Python versions (like min + max). Just the last one isn't going to cover a lot of stuff.. |
@webknjaz I wonder if there are any library/apps in wild that do this? |
Pip itself used to have py3 and py2 runs both in pre-commit, before 2020. I also do so in some places (like Cheroot). One possible strategy is to test every other version or min/max to cover most stuff while still not using too much resources. |
pre-commit tip: if you add several check invocations, it's important to add aliases because several checks have the same id and there's no way to select a specific check without this. |
@webknjaz how do you handle type incompatibilities between different versions in the same code? |
This comment was marked as resolved.
This comment was marked as resolved.
- click==8.1.6 | ||
- pip==23.2 | ||
- build==0.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't got these requirements pinned in pyproject.toml
- Should we do this, or instead remove the boundary here?
Since 21.1 pip has py.typed file, hence many updates on type annotations.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.