-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate prettier-plugin-toml for pre-commit hooks #2053
base: main
Are you sure you want to change the base?
Conversation
Honestly, I think that multiline entries are better. Could you reconfigure it with that in mind? |
I think so too. But sadly prettier-plugin-toml is "still in alpha state". Maybe we should open up an issue? |
Maybe so. Otherwise, we could also drop it. Possible replacements and/or additions to evaluate:
These seem closer to the Python ecosystem, anyway. |
requires = [ | ||
"setuptools==68.1.2", | ||
"wheel==0.41.1", | ||
"fake_static_build_dep" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if having a trailing comma after the last item here would make the formatter to the right thing and keep the list. Worth checking...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not, but that would be lovely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a Feature Request in the plugin project.
I created an issue for ignoring lines. |
I used the workaround described in the issue to at least ignore the one instance, where multiline would be nicer. |
@Horstage Could you rebase and investigate the pre-commit failure? |
In the pre-commit hook, the plugin prettier-plugin-toml is installed, but not used.
Plugins must be loaded either via CLI command
--plugin
or in the configuration file.As there is a configuration file in this project anyways, I added the plugin there.
For more information, see prettier docs.
Contributor checklist
Included tests for the changes.Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.