Add PlaybackForwardingActivity for bridging to new playback module #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChip53
approved these changes
Aug 17, 2021
nielsvanvelzen
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a small change that does not modify any behavior in the normal app flow (and thus is safe for 0.12 inclusion). It adds a new activity "PlaybackForwardingActivity" that is used to bridge all playback requests to the new playback module.
Right now it extracts the to-be-played item from the current playback code and retrieves the BaseItemDto from the api using the SDK. It then quits the activity. This code is backported from my playback scratch branch.
With this the app will not crash anymore when playback is started with the new playback module enabled.
Issues
Part of #1057