Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown support for item descriptions and server disclaimer #1413

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Feb 2, 2022

This pull request adds Markdown support for item descriptions and the server disclaimer (on the login screen). The renderSubtitles function in the PlaybackOverlay still uses HTML.

Changes

  • Add Markwon dependency
  • Add MarkdownRenderer class to create Markdown
  • Support markdown (+basic HTML) for server disclaimer
  • Support markdown (+basic HTML) for item overviews (descriptions)

Issues

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Feb 23, 2022
@nielsvanvelzen nielsvanvelzen added the next-release Pull request related to a future release which is not being worked on yet label Mar 4, 2022
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Mar 5, 2022
@nielsvanvelzen nielsvanvelzen removed the next-release Pull request related to a future release which is not being worked on yet label Mar 17, 2022
@nielsvanvelzen nielsvanvelzen merged commit 808d055 into jellyfin:master Mar 26, 2022
@nielsvanvelzen nielsvanvelzen deleted the markdown branch March 26, 2022 13:31
@nielsvanvelzen nielsvanvelzen added the release-highlight Pull request might be suitable for mentioning in the release blog post label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-highlight Pull request might be suitable for mentioning in the release blog post
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants