-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ripple effect to all buttons #1522
Conversation
d956903
to
44d1af3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes all the buttons to light grey with an even lighter grey highlight. I assume this isn't intentional since it isn't mentioned in the changes.
The Muted Purple theme appears to display colors as expected. All the other themes no longer display their colors (and are grey on grey as shown below)
35da4ee
to
6d87219
Compare
This was partially intended, the buttons now use the styling from Button.Default which has slightly different colors. Some of the buttons didn't use the proper text color though. I've fixed that now. |
The card color was not changed in this PR. |
Follow up for #1507. This PR adds a ripple effect to all buttons1 in the app.
Changes
?attr/buttonRounding
for roundness of buttons?attr/buttonRounding
to3dp
for the default theme7dp
roundness?attr/buttonDefaultHighlightBackground
to change the button background color on highlightIssues
Footnotes
except for live tv if there are any custom buttons ↩