Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ripple effect to all buttons #1522

Merged
merged 7 commits into from
Mar 21, 2022

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Mar 13, 2022

Follow up for #1507. This PR adds a ripple effect to all buttons1 in the app.

Changes

  • Add ripple effect to:
    • NowPlayingBug
    • ServerButtonView
    • ItemRow (track list in audio album view)
    • TextUnderButton (the buttons on details page)
    • Button.Default (buttons used in the login screen)
    • Button.Icon (buttons used in various toolbars)
    • AlphaPicker buttons
  • Always use ?attr/buttonRounding for roundness of buttons
    • Fixes inconsistency between various button types
    • Set ?attr/buttonRounding to 3dp for the default theme
    • The Muted Purple theme still uses 7dp roundness
  • Always send theme to ResourcesCompat.getDrawable calls
  • Reformat some changed XML files
  • Add ?attr/buttonDefaultHighlightBackground to change the button background color on highlight
    • Muted Purple now uses a purple highlight background for all buttons (was only TextUnderButton before)

Issues

Footnotes

  1. except for live tv if there are any custom buttons

@nielsvanvelzen nielsvanvelzen added the next-release Pull request related to a future release which is not being worked on yet label Mar 13, 2022
@nielsvanvelzen nielsvanvelzen force-pushed the ripple-2 branch 2 times, most recently from d956903 to 44d1af3 Compare March 13, 2022 10:37
@nielsvanvelzen nielsvanvelzen removed the next-release Pull request related to a future release which is not being worked on yet label Mar 17, 2022
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review March 17, 2022 12:49
Copy link
Member

@mueslimak3r mueslimak3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes all the buttons to light grey with an even lighter grey highlight. I assume this isn't intentional since it isn't mentioned in the changes.

The Muted Purple theme appears to display colors as expected. All the other themes no longer display their colors (and are grey on grey as shown below)

20220319_181917
20220319_181926
20220319_181951
20220319_182017
20220319_182103

@nielsvanvelzen
Copy link
Member Author

This changes all the buttons to light grey with an even lighter grey highlight. I assume this isn't intentional since it isn't mentioned in the changes.

The Muted Purple theme appears to display colors as expected. All the other themes no longer display their colors (and are grey on grey as shown below)

This was partially intended, the buttons now use the styling from Button.Default which has slightly different colors. Some of the buttons didn't use the proper text color though. I've fixed that now.

@mueslimak3r
Copy link
Member

It looks like only the emerald green theme changed the card background color to match the theme.

I don't think it (or any themes) should do this since it makes the progress bar almost invisible when the progress bar also uses the theme's highlight color.

20220321_013256.jpg

@nielsvanvelzen
Copy link
Member Author

The card color was not changed in this PR.

@nielsvanvelzen nielsvanvelzen merged commit 3483876 into jellyfin:master Mar 21, 2022
@nielsvanvelzen nielsvanvelzen deleted the ripple-2 branch March 21, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants