Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DetailRowView, NowPlayingBug, MediaInfoCardView, TextUnderButton, ObservableHorizontalScrollView, NumberSpinner to Kotlin #1541

Merged
merged 7 commits into from
Mar 26, 2022

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Mar 20, 2022

Rewrite Java views to Kotlin for nullability and to clean the code. XML mostly left intact.

Changes

Old New
DetailRowView.java DetailRowView.kt
NowPlayingBug.java NowPlayingView.kt
MediaInfoCardView.java MediaInfoCardView.kt
TextUnderButton.java TextUnderButton.kt
ObservableHorizontalScrollView.java ObservableHorizontalScrollView.kt
NumberSpinner.java NumberSpinnerView.kt

Issues

@nielsvanvelzen nielsvanvelzen changed the title Draft: Migrate DetailRowView, NowPlayingBug to Kotlin Draft: Migrate DetailRowView, NowPlayingBug, MediaInfoCardView to Kotlin Mar 20, 2022
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Mar 21, 2022
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Mar 21, 2022
@nielsvanvelzen nielsvanvelzen changed the title Draft: Migrate DetailRowView, NowPlayingBug, MediaInfoCardView to Kotlin Draft: Migrate DetailRowView, NowPlayingBug, MediaInfoCardView, TextUnderButton to Kotlin Mar 21, 2022
@nielsvanvelzen nielsvanvelzen changed the title Draft: Migrate DetailRowView, NowPlayingBug, MediaInfoCardView, TextUnderButton to Kotlin Draft: Migrate DetailRowView, NowPlayingBug, MediaInfoCardView, TextUnderButton, NumberSpinner to Kotlin Mar 21, 2022
@nielsvanvelzen nielsvanvelzen changed the title Draft: Migrate DetailRowView, NowPlayingBug, MediaInfoCardView, TextUnderButton, NumberSpinner to Kotlin Draft: Migrate DetailRowView, NowPlayingBug, MediaInfoCardView, TextUnderButton, ObservableHorizontalScrollView, NumberSpinner to Kotlin Mar 21, 2022
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review March 21, 2022 20:32
@nielsvanvelzen nielsvanvelzen changed the title Draft: Migrate DetailRowView, NowPlayingBug, MediaInfoCardView, TextUnderButton, ObservableHorizontalScrollView, NumberSpinner to Kotlin Migrate DetailRowView, NowPlayingBug, MediaInfoCardView, TextUnderButton, ObservableHorizontalScrollView, NumberSpinner to Kotlin Mar 21, 2022
@nielsvanvelzen nielsvanvelzen merged commit 988f920 into jellyfin:master Mar 26, 2022
@nielsvanvelzen nielsvanvelzen deleted the java-view branch March 26, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants