Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ItemSortBy constants instead of hardcoded strings #1564

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

nielsvanvelzen
Copy link
Member

I wanted to check if all sort fields we use in the app were added in jellyfin/jellyfin#7492. Noticed that we don't always use the constants from the apiclient (yeah sorry SDK doesn't have them :p).

Changes

  • Use ItemSortBy constants instead of hardcoded strings
  • Use "SortName" instead of non-existing "Number" sort field in Live TV
    • I looked at the usages of the value and it's actually always compared with the DatePlayed value, so we could even put gibberish in here. I chose SortName because there is one place where it uses SortName if the value is not DatePlayed

Issues

@nielsvanvelzen nielsvanvelzen merged commit 70dd01c into jellyfin:master Mar 26, 2022
@nielsvanvelzen nielsvanvelzen deleted the sortby branch March 26, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants