Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PreferenceStoreTests location #1577

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fix PreferenceStoreTests location #1577

merged 1 commit into from
Mar 29, 2022

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Fix PreferenceStoreTests location (was in java dir with package name dirs)
  • Rename PreferenceStoreTest -> PreferenceStoreTests
  • Remove empty line, optimize imports

Issues

DavidFair
DavidFair reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@DavidFair DavidFair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying those loose ends up 👍
It LGTM (but this is my POV rather than a formal approval)

@nielsvanvelzen nielsvanvelzen merged commit 6674c0f into jellyfin:master Mar 29, 2022
@nielsvanvelzen nielsvanvelzen deleted the javatest branch March 29, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidFair DavidFair DavidFair left review comments

@mueslimak3r mueslimak3r mueslimak3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsvanvelzen @DavidFair @mueslimak3r