Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UserRepository to replace TvApp.getCurrentUserLiveData() #1596

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Add UserRepository to replace TvApp.getCurrentUserLiveData() #1596

merged 1 commit into from
Apr 2, 2022

Conversation

nielsvanvelzen
Copy link
Member

Also migrates all usages of getCurrentUser to the UserDto from the SDK

Changes

  • Add UserRepository
    • Keeps track of the current UserDto (from SDK)
  • Simplify ApiBinder
  • Remove current user stuff from TvApp
    • Keeping getCurrentUser() for now, although you should not use it.
  • Remove livedata library - no longer in use
  • Update currentUser usages, sorry we need to call .toString() for ApiClient stuff so the diff is kinda big....

Issues

@nielsvanvelzen
Add UserRepository to replace TvApp.getCurrentUserLiveData()
4361bc2 
Also migrates all usages of getCurrentUser to the UserDto from the SDK
@nielsvanvelzen nielsvanvelzen requested review from mueslimak3r and thornbill and removed request for mueslimak3r April 2, 2022 08:21
@nielsvanvelzen nielsvanvelzen merged commit 171e919 into jellyfin:master Apr 2, 2022
@nielsvanvelzen nielsvanvelzen deleted the userrepository branch April 2, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mueslimak3r mueslimak3r mueslimak3r approved these changes

@thornbill thornbill Awaiting requested review from thornbill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @mueslimak3r