Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require context in Utils.downMixAudio() #1605

Merged

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Require context in Utils.downMixAudio()
    • I tried to use a proper context where possible but some places use TvApp.getApplication right now because ItemLauncher/MediaManager have no context.

Issues

Copy link
Member

@mueslimak3r mueslimak3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

When testing with downmix to stereo enabled I do see some weird behavior that isn't related to this PR (I checked stable and it's there too). With it enabled the video is transcoded due to "audio not supported" as expected, however ffmpeg runs with -ac 6 (audio channels = 6) as if the setting is just removing codec support but not limiting the number of channels. I tested this with exoplayer.

@nielsvanvelzen nielsvanvelzen merged commit d7ee86e into jellyfin:master Apr 3, 2022
@nielsvanvelzen nielsvanvelzen deleted the downMixAudio-context branch April 3, 2022 11:26
@nielsvanvelzen
Copy link
Member Author

When testing with downmix to stereo enabled I do see some weird behavior that isn't related to this PR (I checked stable and it's there too). With it enabled the video is transcoded due to "audio not supported" as expected, however ffmpeg runs with -ac 6 (audio channels = 6) as if the setting is just removing codec support but not limiting the number of channels. I tested this with exoplayer.

Probably caused by this line, I'm not that familiar with the profile system though;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants