Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use context in ItemRowAdapter/MediaManager, remove TvApp.java #1610

Merged
merged 4 commits into from
Apr 5, 2022
Merged

Use context in ItemRowAdapter/MediaManager, remove TvApp.java #1610

merged 4 commits into from
Apr 5, 2022

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Send context to MediaManager constructor
  • Send context to ItemRowAdapter constructors
  • Always use context in MediaManager (replaces TvApp.getApplication)
  • Always use context in ItemRowAdapter (replaces TvApp.getApplication)
  • Change some function signatures to use Context instead of Activity
  • Change ItemRowAdapter constructor places to send a context
    = Remove TvApp.java - finally after like two years my "delete tvapp.java" project is finished!

Issues

@nielsvanvelzen nielsvanvelzen mentioned this pull request Apr 4, 2022
Closed
@nielsvanvelzen nielsvanvelzen marked this pull request as draft April 4, 2022 20:22
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review April 4, 2022 20:23
@nielsvanvelzen nielsvanvelzen merged commit 98aea02 into jellyfin:master Apr 5, 2022
@nielsvanvelzen nielsvanvelzen deleted the itemrowadapter-context branch April 5, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mueslimak3r mueslimak3r mueslimak3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @mueslimak3r