Refactor preference code #1620
Merged
Refactor preference code #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
force-pushed
the
preference-refactor
branch
from
36ce599
to
17871ce
Compare
mueslimak3r
approved these changes
Apr 15, 2022
app/src/main/java/org/jellyfin/androidtv/util/CoroutineUtils.kt
Outdated
Show resolved
Hide resolved
- Allow migrations in all store types - Remove blocking functions from the preference module - Move Preference.xx functions to global functions
nielsvanvelzen
force-pushed
the
preference-refactor
branch
from
17871ce
to
427a221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to make it easier to work with and maintain the preference code. Blocking function calls removed from the module and replaced with a utility function in the app (only needed for Java compat right now).
Changes
Issues
Depends on ##1619