Implement QuickConnect #1649
Merged
Implement QuickConnect #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
force-pushed
the
quickconnect
branch
from
2e588cc
to
e688a62
Compare
nielsvanvelzen
force-pushed
the
quickconnect
branch
from
e688a62
to
319f1ad
Compare
nielsvanvelzen
force-pushed
the
quickconnect
branch
from
319f1ad
to
4751772
Compare
nielsvanvelzen
requested review from
thornbill and
mueslimak3r
and removed request for
thornbill
This comment was marked as off-topic.
This comment was marked as off-topic.
mueslimak3r
approved these changes
May 2, 2022
There was a problem hiding this comment.
It works!
The new login page looks great.
On the login pages, to my eyes a small margin might be nice between "Please sign in" and "Connecting to ..." 🤷♂️ I tried it with a top margin of 4dp and it looks a little nicer having the extra space between the bottom of the "g" in "sign" and the server ID
|
You're right, that looks slightly better. |
nielsvanvelzen
added
the
release-highlight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds QuickConnect as the new primary authentication method. Password login is still available for servers with QuickConnect disabled or when a user wants to experience the pain that is typing a password with a remote.
Changes
Screenshots
Issues