Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign AddServerFragment #1681

Merged
merged 2 commits into from
May 3, 2022
Merged

Redesign AddServerFragment #1681

merged 2 commits into from
May 3, 2022

Conversation

nielsvanvelzen
Copy link
Member

Use the same styling as the new login fragment for the add server fragment.

Changes

  • Use new input style for server address input
  • Use left-aligned layout
  • Add ViewModel for server add thingy
  • Remove KeyboardFocusChangeListener - no longer used
  • Fix some formatting in the login fragment
  • Fix some bad +id/ in the login xml

Before
image

After
image

Issues

@nielsvanvelzen
Copy link
Member Author

image

@nielsvanvelzen nielsvanvelzen merged commit 6bfe7bb into jellyfin:master May 3, 2022
@nielsvanvelzen nielsvanvelzen deleted the add-server-redesign branch May 3, 2022 16:26
@nielsvanvelzen nielsvanvelzen added the release-highlight Pull request might be suitable for mentioning in the release blog post label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mueslimak3r mueslimak3r mueslimak3r approved these changes

Assignees
No one assigned
Labels
release-highlight Pull request might be suitable for mentioning in the release blog post
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @mueslimak3r