add seperate button to adjust subtitle delay (if subtitles are present). #1731
+184
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mueslimak3r
reviewed
May 23, 2022
tim-vk
force-pushed
the
subtitle_delay_setting
branch
from
7f96d73
to
406973e
Compare
nielsvanvelzen
requested changes
May 24, 2022
...c/main/java/org/jellyfin/androidtv/ui/playback/overlay/action/AdjustSubtitleDelayAction.java
Outdated
Show resolved
Hide resolved
...main/java/org/jellyfin/androidtv/ui/playback/overlay/CustomPlaybackTransportControlGlue.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/SubtitleDelayPopup.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/AudioDelayPopup.java
Outdated
Show resolved
Hide resolved
ExoPlayer does not support modifying subtitle timings (see here). The reason why I chose the same type of solution as with the current audiodelay feature. |
|
Ok makes sense to only add it for libvlc then |
tim-vk
force-pushed
the
subtitle_delay_setting
branch
from
406973e
to
284651e
Compare
|
Ok, so new files are converted to kotlin. I've struggled a bit with merging the two buttons into a single button. But I got it working. I've kept that as a seperate commit but I can squash them if desired. |
nielsvanvelzen
requested changes
May 28, 2022
...main/java/org/jellyfin/androidtv/ui/playback/overlay/CustomPlaybackTransportControlGlue.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/overlay/action/SettingAction.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/overlay/action/SettingAction.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/overlay/action/SettingAction.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/overlay/action/SettingAction.kt
Outdated
Show resolved
Hide resolved
Fix magic numbers Fix formatting Remove superfluous member variables
nielsvanvelzen
requested changes
May 28, 2022
Move all logic from `init` to constructor.
nielsvanvelzen
added
the
release-highlight
|
I've pushed some final changes so we can merge:
Thanks for your contribution! |
nielsvanvelzen
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
fixes #1636
fixes #1234
fixes #640
test
further improvement
It would probably be nicer to share functionality with the audio delay button: but I'm unsure what would be the nicest way to achieve that. My guess would be:
delay-popup.xmlinstead of seperateaudio-delay-popup.xmlandsubtitle-delay-popup.xmlAdjustDelayActioninstead of two seperate onesAdjustDelayPopupwhich determines if one (or both) settings should be shown & adjusts size accordingly.Not entirely sure if that would work. And my gut feeling says that there should be a way to keep the two
.xmlfiles seperate & add a level in between that merges the two. Not entirely sure how though. Input appreciated.