Propagate errors from ItemRowAdapter to RetrieveFinishedListener #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mueslimak3r
reviewed
May 28, 2022
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
Outdated
Show resolved
Hide resolved
mueslimak3r
approved these changes
May 28, 2022
nielsvanvelzen
force-pushed
the
itemrowadapter-error
branch
from
5e00692
to
22b50e1
Compare
nielsvanvelzen
force-pushed
the
itemrowadapter-error
branch
from
22b50e1
to
1cfdd1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the app would occasionally show volley clienterror toasts that provide 0 feedback to the end-user about the issue. Now the error is propagated to the RetrieveFinishedListener (in StdGridGragment and SearchRunnable) which both casually ignore the error.
Changes
Issues