-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add showing additional parts #1775
Conversation
0830f36
to
d3bbcbb
Compare
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
Show resolved
Hide resolved
d3bbcbb
to
23a9504
Compare
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.java
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.java
Fixed
Show fixed
Hide fixed
@@ -279,6 +281,14 @@ | |||
queryType = QueryType.Specials; | |||
} | |||
|
|||
public ItemRowAdapter(Context context, AdditionalPartsQuery query, Presenter presenter, ArrayObjectAdapter parent) { |
Check notice
Code scanning / Android Lint
Unknown nullness
@@ -279,6 +281,14 @@ | |||
queryType = QueryType.Specials; | |||
} | |||
|
|||
public ItemRowAdapter(Context context, AdditionalPartsQuery query, Presenter presenter, ArrayObjectAdapter parent) { |
Check notice
Code scanning / Android Lint
Unknown nullness
@@ -279,6 +281,14 @@ | |||
queryType = QueryType.Specials; | |||
} | |||
|
|||
public ItemRowAdapter(Context context, AdditionalPartsQuery query, Presenter presenter, ArrayObjectAdapter parent) { |
Check notice
Code scanning / Android Lint
Unknown nullness
@@ -279,6 +281,14 @@ | |||
queryType = QueryType.Specials; | |||
} | |||
|
|||
public ItemRowAdapter(Context context, AdditionalPartsQuery query, Presenter presenter, ArrayObjectAdapter parent) { |
Check notice
Code scanning / Android Lint
Unknown nullness
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/data/querying/AdditionalPartsQuery.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapter.java
Outdated
Show resolved
Hide resolved
Do you want me to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need, it looks fine like this. Thanks!
Changes
Adds showing Additional parts above Cast / Crew for Movies. Includes what translations I could get from jellyfin-web. I have very limited Android app experience, so this is mostly copied from how the specials and suggestions are retrieved and displayed. Tested with Lord of the Rings extended editions on an Nvidia Shield TV Pro.