Rewrite crash reporting #1820
Merged
Rewrite crash reporting #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| class AcraPluginLoader(vararg plugins: Class<out Plugin>) : PluginLoader { | ||
| private val simplePluginLoader = SimplePluginLoader(*plugins) |
Check notice
Code scanning
In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty.
|
Right now 2 preferences are removed:
Additionally, because the options moved to a different preference store, the value is reset and reporting is now enabled for everyone when updating. |
nielsvanvelzen
force-pushed
the
server-crash-report
branch
from
a7f1a9f
to
30e3893
Compare
|
Additional changes pushed:
|
nielsvanvelzen
added
the
release-highlight
nielsvanvelzen
force-pushed
the
server-crash-report
branch
from
30e3893
to
8975893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our current crash reporting with a new implementation that sends the logs to the last used Jellyfin server. The reports use markdown with a YAML header indicating the format. This can be used in the future if we create a log viewer in jellyfin-web.
The crash reporting functionality caches the Jellyfin server url and access token when restoring a session (login/app open). When the app crashes these values are used to manually connect to the Jellyfin server instead of using the SDK. This is so we can catch SDK issues too.
Changes
Issues