-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust TV detection logic #1822
Conversation
app/src/main/java/org/jellyfin/androidtv/data/repository/NotificationsRepository.kt
Fixed
Show fixed
Hide fixed
The Android TV app is not meant for normal Android devices, so the notification does exactly what it should do. The mobile app is for non-TV devices. |
This ignores the reality that the majority of TV media-boxes run Android and not AndroidTV. Most of the devices in those list all run Android and are yet only designed for TV use: So "Jellyfin Android TV" runs fine on all those devices, since there is not any AndroidTV specific code and this should remain so. |
Here is a sort-able list with OS column: |
Ok so we'd need to change the detection logic because those manufacturers didn't change the device mode flag. I don't think adding the "normal" type to the list is the right fix as that hides the notification on phones/tablets, where it should show. |
I will see what i can find, possible solutions are:
any other ideas? |
I think we can check for touch screen support. I'm not aware of any television with touch support (the official Android TV apps don't even support it). |
Depends on how this is detected? So if we can detect real touch-input and distinguish it from those Air-mouse devices, this could work along with a basic aspect-ratio check? |
A cursor is not a touch screen. I think using |
ah cool, will test this asap on my device. Btw i sold my ShieldTv/FireTv, so keep in mind that i only test via one of those Android 9 devices. |
80e2cb8
to
660185d
Compare
660185d
to
020b10a
Compare
@nielsvanvelzen touch detection does not work, my device reports a touchpad and even a accelerometer... I think thats all just to emulate things, so apps don't refuse to run. Yet i found the |
app/src/main/java/org/jellyfin/androidtv/data/repository/NotificationsRepository.kt
Fixed
Show fixed
Hide fixed
Tested on a bunch of devices & emulator:
So I think it works as expected |
app/src/main/java/org/jellyfin/androidtv/data/repository/NotificationsRepository.kt
Outdated
Show resolved
Hide resolved
…icationsRepository.kt Co-authored-by: Niels van Velzen <[email protected]>
@nielsvanvelzen Ah nice, btw any chance to get the new dolby vision stuff working for BaseItemDto or in some other way? |
Rewrite all playback code to use the SDK, that's the only way. |
Changes
Issues
All TV media boxes running normal Android, instead of AndroidTV will fail this check.
All none AndroidTV certified devices run Android, which is the largest segment for TV media devices.
The main reason is the harder AndroidTV certification process and licensing cost, so this will not change in the future.
So we should never rely on anything specific AndroidTv related.