Add audio night mode (as preference) to level out/compress audio volume. #1852
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/org/jellyfin/androidtv/preference/constant/AudioNightModeBehavior.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/preference/UserPreferences.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/preference/constant/AudioNightModeBehavior.kt
Outdated
Show resolved
Hide resolved
|
Definitely happy to take feedback on the naming. "Night mode" does seem to be a fairly common name for this feature though (Sony, Sonos and Denon use this name on their TVs / soundbars). |
nielsvanvelzen
added
the
next-release
|
|
||
| // Volume normalisation (audio night mode). | ||
| if (nightModeEnabled) { | ||
| this.enableAudioNightMode(mExoPlayer.getAudioSessionId()); |
There was a problem hiding this comment.
Will this be an exoplayer only feature or will "night mode" also work with libVLC?
There was a problem hiding this comment.
TBH I'm not sure at this point. I will test it today and find out.
There was a problem hiding this comment.
It will be ExoPlayer only
If this name is commonly used in other applications it makes sense to use it here too. |
app/src/main/java/org/jellyfin/androidtv/ui/preference/screen/PlaybackPreferencesScreen.kt
Show resolved
Hide resolved
nielsvanvelzen
removed
the
next-release
app/src/main/java/org/jellyfin/androidtv/ui/playback/VideoManager.java
Outdated
Show resolved
Hide resolved
|
Hey @robertduplock there are still some comments open in this PR before we can merge. |
nielsvanvelzen
added
playback
nielsvanvelzen
force-pushed
the
feature/add-audio-night-mode
branch
from
c882d81
to
9d19ebb
Compare
|
I've rebased and squashed your branch and fixed the remaining feedback. Unfortunately the commit author got lost when I removed the changes to the en-gb translations. |
Add a togglable feature, "Audio night mode", which compresses a video's audio stream and tweaks the EQ, to solve the issue of "dialogue too quiet, explosions too loud".
Changes
Added extra option "Audio night mode" under "Settings > Playback > Audio"