Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button order on item details screen #1860

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Jul 18, 2022

Changes
Updates the button ordering on the item details screen to try to be more consistent:

  1. Shuffle button is now before the Play Trailers button (this is the order in web and I think shuffle is more likely to be used more frequently)
  2. Button order in the "Other Options" menu should better match their order when not in the menu

One oddity in the current code is that the Watched button never moves to the menu even though buttons preceding it do... Should this be updated so it will move to the menu before the others (primarily happens with the Play Trailers button for series)?

Issues
N/A

@thornbill thornbill added the enhancement New feature or request label Jul 18, 2022
@nielsvanvelzen
Copy link
Member

One oddity in the current code is that the Watched button never moves to the menu even though buttons preceding it do... Should this be updated so it will move to the menu before the others (primarily happens with the Play Trailers button for series)?

I think this is because it's a toggle and adding that to the submenu is too much work?

@nielsvanvelzen nielsvanvelzen merged commit c2ec0cd into jellyfin:master Jul 20, 2022
@thornbill thornbill deleted the details-button-order branch July 20, 2022 13:35
@thornbill
Copy link
Member Author

The favorite toggle is in the submenu... 🤷‍♂️

@nielsvanvelzen
Copy link
Member

Well maybe it's just because legacy code then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants