Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update more channels button #1875

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Update more channels button #1875

merged 1 commit into from
Jul 23, 2022

Conversation

thornbill
Copy link
Member

Changes

  • Updates GuidePagingButton to use the program_grid_cell layout to be more consistent with all other grid entries
  • Removes the gray gradient and uses the default button background for the paging button
  • Updates grid cells to handle focus correctly by default
  • Ellipsizes program names in grid cells

Default style:
guide-more-button

With focus:
guide-more-button-focus

Depends on
#1867

Issues
N/A

@thornbill thornbill added the enhancement New feature or request label Jul 22, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 22, 2022
View reviewed changes
app/src/main/java/org/jellyfin/androidtv/ui/GuidePagingButton.java
us.setBackgroundResource(R.drawable.gray_gradient);
}
@Override
protected void onFocusChanged(boolean hasFocus, int direction, Rect previouslyFocused) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Jul 22, 2022
@thornbill thornbill force-pushed the update-more-channels-button branch from 7356f9b to 98b7170 Compare July 23, 2022 05:37
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Jul 23, 2022
@thornbill thornbill marked this pull request as ready for review July 23, 2022 05:46
@nielsvanvelzen nielsvanvelzen merged commit 1151de2 into jellyfin:master Jul 23, 2022
@thornbill thornbill deleted the update-more-channels-button branch July 23, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thornbill @nielsvanvelzen @jellyfin-bot