Use AsyncImageView in ClockUserView #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
force-pushed
the
clock-asyncimageview
branch
from
1eede40
to
ef46b51
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // FIXME: Glide is unable to scale the image when transitions are enabled | ||
| //.transition(DrawableTransitionOptions.withCrossFade(crossFadeDuration.inWholeMilliseconds.toInt())) | ||
| .load(url ?: placeholder).apply { | ||
| placeholder(placeholderOrBlurHash) |
Check warning
Code scanning / Android Lint
Ignoring results
| //.transition(DrawableTransitionOptions.withCrossFade(crossFadeDuration.inWholeMilliseconds.toInt())) | ||
| .load(url ?: placeholder).apply { | ||
| placeholder(placeholderOrBlurHash) | ||
| error(placeholder) |
Check warning
Code scanning / Android Lint
Ignoring results
| .load(url ?: placeholder).apply { | ||
| placeholder(placeholderOrBlurHash) | ||
| error(placeholder) | ||
| if (circleCrop) circleCrop() |
Check warning
Code scanning / Android Lint
Ignoring results
nielsvanvelzen
added
the
refactor
crobibero
approved these changes
Aug 14, 2022
thornbill
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer AsyncImageView for displaying (networked) images since it allows us to easily set the fallback/blurhash and moves all Glide code to a single place. This PR migrates the ClockUserView.
Changes
Issues