Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants from SDK #1983

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Use constants from SDK #1983

merged 4 commits into from
Aug 17, 2022

Conversation

nielsvanvelzen
Copy link
Member

This is mostly binary compatible so some files only show the import line changing.

Changes

  • Replace legacy apiclient ItemSortBy, MediaType and CollectionType with SDK supplied constants
  • Replace some hardcoded strings with the above mentioned constants
  • Remove games collection type usage

Issues

@nielsvanvelzen nielsvanvelzen added sdk-migration To fix this we need to migrate some code to the new SDK refactor Improvements to code realiability, readability and quality labels Aug 16, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Aug 16, 2022
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Aug 17, 2022
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Aug 17, 2022
@nielsvanvelzen nielsvanvelzen merged commit 57c3b7f into jellyfin:master Aug 17, 2022
@nielsvanvelzen nielsvanvelzen deleted the sdk-constant branch August 17, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality sdk-migration To fix this we need to migrate some code to the new SDK
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nielsvanvelzen @thornbill @crobibero @jellyfin-bot