Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify reportPlaybackStopped code #1993

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Simplify reportPlaybackStopped code #1993

merged 1 commit into from
Aug 19, 2022

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Removed the two unused parameters in reportPlaybackStopped
  • Remove dependency on current session in ReportingHelper.reportStopped

Issues

@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Aug 19, 2022
@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Aug 19, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 19, 2022
View reviewed changes
app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackManager.java
@@ -113,7 +113,7 @@
apiClient.ReportPlaybackProgressAsync(info, response);
}

public void reportPlaybackStopped(PlaybackStopInfo info, final StreamInfo streamInfo, final String serverId, String userId, final ApiClient apiClient, final EmptyResponse response) {
public void reportPlaybackStopped(PlaybackStopInfo info, final StreamInfo streamInfo, final ApiClient apiClient, final EmptyResponse response) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackManager.java
@@ -113,7 +113,7 @@
apiClient.ReportPlaybackProgressAsync(info, response);
}

public void reportPlaybackStopped(PlaybackStopInfo info, final StreamInfo streamInfo, final String serverId, String userId, final ApiClient apiClient, final EmptyResponse response) {
public void reportPlaybackStopped(PlaybackStopInfo info, final StreamInfo streamInfo, final ApiClient apiClient, final EmptyResponse response) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackManager.java
@@ -113,7 +113,7 @@
apiClient.ReportPlaybackProgressAsync(info, response);
}

public void reportPlaybackStopped(PlaybackStopInfo info, final StreamInfo streamInfo, final String serverId, String userId, final ApiClient apiClient, final EmptyResponse response) {
public void reportPlaybackStopped(PlaybackStopInfo info, final StreamInfo streamInfo, final ApiClient apiClient, final EmptyResponse response) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackManager.java
@@ -113,7 +113,7 @@
apiClient.ReportPlaybackProgressAsync(info, response);
}

public void reportPlaybackStopped(PlaybackStopInfo info, final StreamInfo streamInfo, final String serverId, String userId, final ApiClient apiClient, final EmptyResponse response) {
public void reportPlaybackStopped(PlaybackStopInfo info, final StreamInfo streamInfo, final ApiClient apiClient, final EmptyResponse response) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
crobibero
crobibero approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@crobibero crobibero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much easier to review with whitespace disabled :)

@nielsvanvelzen nielsvanvelzen merged commit e6b7ca8 into jellyfin:master Aug 19, 2022
@nielsvanvelzen nielsvanvelzen deleted the simplify-report-stopped branch August 19, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero