Migrate most of KeyProcessor to SDK types #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
sdk-migration
|
Um can you also mark the old api client types as deprecated? I'm going mad trying to figure out what import is actually valid and which was just auto added. |
|
The legacy apiclient is unmaintained for over a year now and it's not possible to create new versions for it anymore. So no, I can't add those markers. |
crobibero
approved these changes
Aug 20, 2022
| mCurrentRowItemNdx = rowItem.getIndex(); | ||
| mCurrentItemId = item.getId(); | ||
| mCurrentItemId = item.getId().toString(); |
There was a problem hiding this comment.
Why remove item from L294 but keep it here?
There was a problem hiding this comment.
rowItem.getBaseItem() is the old BaseItemDto (from the apiclient) which we're migrating from. So I use the SDK one when I can, in this case I can't use it for mCurrentItem but can for the id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still some stuff with old apiclient types because they are used in other files and are a PITA to migrate right now.
Changes
Issues