Rewrite MediaCodecCapabilitiesTest in Kotlin #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
the
refactor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| CodecProfileLevel.AVCLevel4 | ||
| ) | ||
|
|
||
| private fun hasDecoder(mime: String, profile: Int, level: Int): Boolean { |
Check notice
Code scanning
Excessive nesting leads to hidden complexity. Prefer extracting code to make it easier to understand.
| // H.263 levels are not completely ordered: | ||
| // Level45 support only implies Level10 support | ||
| if (mime.equals(MediaFormat.MIMETYPE_VIDEO_H263, ignoreCase = true)) { | ||
| if (profileLevel.level != level && profileLevel.level == CodecProfileLevel.H263Level45 && level > CodecProfileLevel.H263Level10) { |
Check notice
Code scanning
Line detected, which is longer than the defined maximum line length in the code style.
Comment on lines
+31
to
+43
| for (profileLevel in capabilities.profileLevels) { | ||
| if (profileLevel.profile != profile) continue | ||
|
|
||
| // H.263 levels are not completely ordered: | ||
| // Level45 support only implies Level10 support | ||
| if (mime.equals(MediaFormat.MIMETYPE_VIDEO_H263, ignoreCase = true)) { | ||
| if (profileLevel.level != level && profileLevel.level == CodecProfileLevel.H263Level45 && level > CodecProfileLevel.H263Level10) { | ||
| continue | ||
| } | ||
| } | ||
|
|
||
| if (profileLevel.level >= level) return true | ||
| } |
Check notice
Code scanning
The loop contains more than one break or continue statement. The code should be refactored to increase readability.
crobibero
approved these changes
Aug 27, 2022
nielsvanvelzen
force-pushed
the
media-codec-capabilities-test-kt
branch
from
a361051
to
e9bba78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues