Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite ChapterItemInfo to not use the apiclient #2025

Merged
merged 2 commits into from
Sep 3, 2022
Merged

Rewrite ChapterItemInfo to not use the apiclient #2025

merged 2 commits into from
Sep 3, 2022

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Rewrite ChapterItemInfo to not use the apiclient
    • Copied all properties from the base and remove the unused once, converted to Kotlin data class

Issues

@nielsvanvelzen nielsvanvelzen added sdk-migration To fix this we need to migrate some code to the new SDK refactor Improvements to code realiability, readability and quality labels Sep 3, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Sep 3, 2022
@nielsvanvelzen nielsvanvelzen merged commit c8f757f into jellyfin:master Sep 3, 2022
@nielsvanvelzen nielsvanvelzen deleted the chapter-item-info-sdk branch September 3, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality sdk-migration To fix this we need to migrate some code to the new SDK
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero