Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use repeatOnLifecycle instead of launchWhenX functions #2108

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

nielsvanvelzen
Copy link
Member

The launchWhenX functions have a performance penalty, using repeatOnLifecycle is the recommended function to use.

Changes

  • Always use repeatOnLifecycle instead of launchWhenX functions

Issues

@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Sep 27, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Sep 27, 2022
@nielsvanvelzen nielsvanvelzen merged commit d0d5d29 into jellyfin:master Sep 28, 2022
@nielsvanvelzen nielsvanvelzen deleted the lifecycle-extensions branch September 28, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant