Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomMessageRepository, remove BaseActivity #2128

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Add CustomMessageRepository
  • Remove BaseActivity

Issues

@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Sep 30, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Sep 30, 2022
@@ -65,7 +65,7 @@

private Lazy<ApiClient> apiClient = inject(ApiClient.class);

public LiveProgramDetailPopup(BaseActivity activity, LiveTvGuide tvGuide, int width, EmptyResponse tuneAction) {
public LiveProgramDetailPopup(Activity activity, LiveTvGuide tvGuide, int width, EmptyResponse tuneAction) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@@ -65,7 +65,7 @@

private Lazy<ApiClient> apiClient = inject(ApiClient.class);

public LiveProgramDetailPopup(BaseActivity activity, LiveTvGuide tvGuide, int width, EmptyResponse tuneAction) {
public LiveProgramDetailPopup(Activity activity, LiveTvGuide tvGuide, int width, EmptyResponse tuneAction) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@@ -65,7 +65,7 @@

private Lazy<ApiClient> apiClient = inject(ApiClient.class);

public LiveProgramDetailPopup(BaseActivity activity, LiveTvGuide tvGuide, int width, EmptyResponse tuneAction) {
public LiveProgramDetailPopup(Activity activity, LiveTvGuide tvGuide, int width, EmptyResponse tuneAction) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

public RecordPopup(BaseActivity activity, View anchorView, int left, int top, int width) {
public RecordPopup(Activity activity, View anchorView, int left, int top, int width) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

public RecordPopup(BaseActivity activity, View anchorView, int left, int top, int width) {
public RecordPopup(Activity activity, View anchorView, int left, int top, int width) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@nielsvanvelzen nielsvanvelzen merged commit 5a8108a into jellyfin:master Oct 1, 2022
@nielsvanvelzen nielsvanvelzen deleted the messagerepository branch October 8, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant