Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PictureViewerFragment as destination #2149

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Add PictureViewerFragment as destination #2149

merged 1 commit into from
Oct 8, 2022

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Add PictureViewerFragment as destination
  • Move feature flag check for PictureViewerFragment to ItemLauncher
  • Remvoe PictureViewerActivity
  • Fix crash when trying to view a photo (for both old and new UI)

Issues

@nielsvanvelzen nielsvanvelzen added bug Something isn't working enhancement New feature or request photos Issue related to photo's and photo albums labels Oct 7, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Oct 7, 2022
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review October 7, 2022 18:29
@nielsvanvelzen nielsvanvelzen merged commit b0c642a into jellyfin:master Oct 8, 2022
@nielsvanvelzen nielsvanvelzen deleted the photo-fragment branch October 8, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request photos Issue related to photo's and photo albums
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @thornbill