Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite small playback related files in Kotlin #2164

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Rewrite small playback related files in Kotlin #2164

merged 2 commits into from
Oct 12, 2022

Conversation

nielsvanvelzen
Copy link
Member

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 11, 2022
View reviewed changes
app/src/main/java/org/jellyfin/androidtv/ui/playback/overlay/action/ClosedCaptionsAction.kt
initializeWithIcon(R.drawable.ic_select_subtitle)
}

override fun handleClickAction(

Check warning

Code scanning / detekt

Excessive nesting leads to hidden complexity. Prefer extracting code to make it easier to understand.

Function handleClickAction is nested too deeply.
app/src/main/java/org/jellyfin/androidtv/ui/playback/overlay/action/SelectAudioAction.kt
initializeWithIcon(R.drawable.ic_select_audio)
}

override fun handleClickAction(

Check warning

Code scanning / detekt

Excessive nesting leads to hidden complexity. Prefer extracting code to make it easier to understand.

Function handleClickAction is nested too deeply.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 11, 2022
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android Lint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review October 11, 2022 15:27
@nielsvanvelzen nielsvanvelzen merged commit 6960c4e into jellyfin:master Oct 12, 2022
@nielsvanvelzen nielsvanvelzen deleted the playback-kt branch October 12, 2022 14:33
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Oct 28, 2022
@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero