Add Jetpack Compose support #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
force-pushed
the
compose
branch
from
5e14e7c
to
068395b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating UI with compose is a billion time easier to do. We're already using it on our mobile app and I've used it for some of my own already. This PR is a starter that just adds the dependencies and build configuration to allow usage of compose in the Android TV app.
Of course because we're a television app there are some issues, like with everything Android TV:
With these caveats we can't switch our interactive UI (everything that supports dpad controls) but we can rewrite stuff like the backgroundmanager, screensaver, audio now playing screensaver etc.
Google is also working on compose support for tv with the new androidx.tv library. So hopefully we can use compose in more places soon.
Changes
Try compose
I have a second branch that migrates the now playing widget that shows up when playing music. This highlights the focus issue but also shows how easy compose is to work with:
https://github.com/nielsvanvelzen/jellyfin-androidtv/tree/compose-nowplayingview
Issues