Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StartupActivity set destination is ignored #2228

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

nielsvanvelzen
Copy link
Member

When opening items via search/leanback integration the MainActivity would reset the navigation history so the item never showed. It just opened the home screen.

Changes

  • Fix StartupActivity set destination is ignored

Issues

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Oct 30, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Oct 30, 2022
navigationRepository.navigate(destination);
}

public static Destination.Fragment getUserViewDestination(final org.jellyfin.sdk.model.api.BaseItemDto baseItem) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
navigationRepository.navigate(destination);
}

public static Destination.Fragment getUserViewDestination(final org.jellyfin.sdk.model.api.BaseItemDto baseItem) {

Check notice

Code scanning / Android Lint

Unknown nullness

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@nielsvanvelzen nielsvanvelzen merged commit 5acbae0 into jellyfin:master Oct 31, 2022
@nielsvanvelzen nielsvanvelzen deleted the startup-destination branch October 31, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant