Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ItemRowAdapterHelper.setItems for more row types #2265

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

nielsvanvelzen
Copy link
Member

When resuming a fragment with an paged adapter that had an item focused after the first page the leanback library would try to focus an item that wasn't ready yet. I fixed this in #2246 for ItemQuery but we also use pages for artists and a few other types.

Changes

  • Use ItemRowAdapterHelper.setItems for artists
  • Use ItemRowAdapterHelper.setItems for views
  • Use ItemRowAdapterHelper.setItems for search results
  • Use ItemRowAdapterHelper.setItems for latest items
  • Filter out null values in ItemRowAdapterHelper.setItems

Issues

Fixes #2260

@nielsvanvelzen nielsvanvelzen added bug Something isn't working crash Bug causing app crashes labels Nov 15, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Nov 15, 2022
@nielsvanvelzen nielsvanvelzen merged commit 0c966e1 into jellyfin:master Nov 16, 2022
@nielsvanvelzen nielsvanvelzen deleted the grid-crashes branch November 16, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crash Bug causing app crashes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexOutOfBoundsException in music
2 participants