Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember button focus on summary page #2297

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

teobaranga
Copy link
Contributor

Fixes remembering the last selected button so that it's reselected when coming back to the buttons row. As far as I can tell from other places in the app and other TV apps in general, this seems to be standard behaviour.

Side note: big fan of Jellyfin, keep up the good work 👍

@nielsvanvelzen
Copy link
Member

This change doesn't appear to do anything for me. I tested it by opening an episode and trying both the "previous episode" button and the "go to series" button and then going back with the system back button again. In both cases the play button (first in the row) was focused.

@teobaranga
Copy link
Contributor Author

Ahh sorry, I wasn't clear in the description. I meant that the button is remembered when navigating up or down on the same screen with the buttons. Eg. when you're on the series details screen and you navigate down to select a season, when coming back up to the buttons row, the last selected button should be reselected. Without these changes, the middle button in that row is always reselected for some reason. Hope that clears it up!

@nielsvanvelzen
Copy link
Member

Right, I understand it now. It works as expected but I think the the change should be moved to DetailRowView instead since so it manages it's own layout.

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Dec 3, 2022
@teobaranga
Copy link
Contributor Author

That makes sense, thanks, updated 👍

@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Dec 4, 2022
@nielsvanvelzen nielsvanvelzen merged commit 0c8fe45 into jellyfin:master Dec 4, 2022
@nielsvanvelzen
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants