Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mActivity from EnhancedBrowseFragment #2301

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Remove mActivity from EnhancedBrowseFragment #2301

merged 1 commit into from
Dec 3, 2022

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Remove mActivity from EnhancedBrowseFragment
    • Use requireContext() or requireActivity() instead
  • Remove onResponse handler in BrowseScheduleFragment (changing the activity title doesn't do anything on Android TV)

Issues

@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Nov 29, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Nov 29, 2022
@nielsvanvelzen nielsvanvelzen mentioned this pull request Nov 29, 2022
Closed
@nielsvanvelzen nielsvanvelzen merged commit 6020ed2 into jellyfin:master Dec 3, 2022
@nielsvanvelzen nielsvanvelzen deleted the mactivity branch December 3, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
1 participant
@nielsvanvelzen